From 6c70d6a60b286f7cfbbde4e428d41c8de2c7e77a Mon Sep 17 00:00:00 2001
From: diogo464 <diogo464@d464.sh>
Date: Thu, 14 Aug 2025 15:34:42 +0100
Subject: feat: improve DriveLogEntry types with discriminated unions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Replace generic DriveLogEntry with action-specific discriminated unions
- Add DriveLogEntryCreateFile, CreateDir, Remove, Rename types
- Update Drive_log parsing to create correct union types based on action
- Add type guards (isCreateFileEntry, isRenameEntry, etc.) for safe access
- Enhance History UI to properly display rename operations (old → new)
- Change log_id to revision to match Rust OperationHeader structure
- Improve type safety and maintainability

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 frontend/components/history/HistoryView.tsx | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

(limited to 'frontend/components')

diff --git a/frontend/components/history/HistoryView.tsx b/frontend/components/history/HistoryView.tsx
index b01e4c6..d9d3dc2 100644
--- a/frontend/components/history/HistoryView.tsx
+++ b/frontend/components/history/HistoryView.tsx
@@ -1,4 +1,4 @@
-import { DriveLogEntry } from "@/lib/drive_types"
+import { DriveLogEntry, isCreateFileEntry, isRenameEntry } from "@/lib/drive_types"
 import { DriveHeader } from "@/components/drive/DriveHeader"
 import { Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from "@/components/ui/table"
 import { Button } from "@/components/ui/button"
@@ -102,7 +102,7 @@ export function HistoryView({ entries, currentPage, hasNextPage, hasPrevPage, to
                 </TableRow>
               ) : (
                 entries.map((entry) => (
-                  <TableRow key={entry.log_id} className="hover:bg-muted/50">
+                  <TableRow key={entry.revision} className="hover:bg-muted/50">
                     <TableCell className="font-mono text-sm">
                       {formatDateTime(entry.timestamp)}
                     </TableCell>
@@ -115,19 +115,23 @@ export function HistoryView({ entries, currentPage, hasNextPage, hasPrevPage, to
                       {entry.email}
                     </TableCell>
                     <TableCell className="font-mono text-sm max-w-md truncate">
-                      {entry.action === "create_file" && entry.blob_id !== "-" ? (
+                      {isCreateFileEntry(entry) ? (
                         <Link 
                           href={`/blob/${entry.blob_id}?filename=${encodeURIComponent(entry.path.split('/').pop() || 'download')}`}
                           className="text-blue-600 hover:text-blue-800 hover:underline"
                         >
                           {entry.path}
                         </Link>
+                      ) : isRenameEntry(entry) ? (
+                        <span>
+                          {entry.old_path} → {entry.new_path}
+                        </span>
                       ) : (
-                        entry.path
+                        'path' in entry ? entry.path : ''
                       )}
                     </TableCell>
                     <TableCell>
-                      {formatFileSize(entry.size)}
+                      {isCreateFileEntry(entry) ? formatFileSize(entry.size) : '-'}
                     </TableCell>
                   </TableRow>
                 ))
-- 
cgit