From 94c208b52a55337658baa894c699c428fc67a449 Mon Sep 17 00:00:00 2001
From: Anton Pöhl <apoehl@posteo.net>
Date: Sun, 13 Apr 2025 20:26:26 +0200
Subject: Stm32 usart: better names for open drain pin modes

---
 embassy-stm32/src/usart/mod.rs              | 12 ++++++------
 examples/stm32g0/src/bin/onewire_ds18b20.rs |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/embassy-stm32/src/usart/mod.rs b/embassy-stm32/src/usart/mod.rs
index 49f536799..48f9a84fa 100644
--- a/embassy-stm32/src/usart/mod.rs
+++ b/embassy-stm32/src/usart/mod.rs
@@ -142,20 +142,20 @@ pub enum HalfDuplexReadback {
 pub enum OutputConfig {
     /// Push pull allows for faster baudrates, no internal pullup
     PushPull,
-    /// Open drain output using external pull down resistor
-    OpenDrainExternal,
+    /// Open drain output (external pull up needed)
+    OpenDrain,
     #[cfg(not(gpio_v1))]
-    /// Open drain output using internal pull up resistor
-    OpenDrainInternal,
+    /// Open drain output with internal pull up resistor
+    OpenDrainPullUp,
 }
 
 impl OutputConfig {
     const fn af_type(self) -> AfType {
         match self {
             OutputConfig::PushPull => AfType::output(OutputType::PushPull, Speed::Medium),
-            OutputConfig::OpenDrainExternal => AfType::output(OutputType::OpenDrain, Speed::Medium),
+            OutputConfig::OpenDrain => AfType::output(OutputType::OpenDrain, Speed::Medium),
             #[cfg(not(gpio_v1))]
-            OutputConfig::OpenDrainInternal => AfType::output_pull(OutputType::OpenDrain, Speed::Medium, Pull::Up),
+            OutputConfig::OpenDrainPullUp => AfType::output_pull(OutputType::OpenDrain, Speed::Medium, Pull::Up),
         }
     }
 }
diff --git a/examples/stm32g0/src/bin/onewire_ds18b20.rs b/examples/stm32g0/src/bin/onewire_ds18b20.rs
index 75519bbf2..62f8711a6 100644
--- a/examples/stm32g0/src/bin/onewire_ds18b20.rs
+++ b/examples/stm32g0/src/bin/onewire_ds18b20.rs
@@ -22,7 +22,7 @@ fn create_onewire(p: embassy_stm32::Peripherals) -> OneWire<UartTx<'static, Asyn
     });
 
     let mut config = Config::default();
-    config.tx_config = OutputConfig::OpenDrainExternal;
+    config.tx_config = OutputConfig::OpenDrain;
 
     let usart = Uart::new_half_duplex(
         p.USART1,
@@ -53,7 +53,7 @@ fn create_onewire(p: embassy_stm32::Peripherals) -> OneWire<BufferedUartTx<'stat
 
     const BUFFER_SIZE: usize = 16;
     let mut config = Confi::default();
-    config.tx_config = OutputConfig::OpenDrainExternal;
+    config.tx_config = OutputConfig::OpenDrain;
     let tx_buf: &mut [u8; BUFFER_SIZE] = singleton!(TX_BUF: [u8; BUFFER_SIZE] = [0; BUFFER_SIZE]).unwrap();
     let rx_buf: &mut [u8; BUFFER_SIZE] = singleton!(RX_BUF: [u8; BUFFER_SIZE] = [0; BUFFER_SIZE]).unwrap();
     let usart = BufferedUart::new_half_duplex(
-- 
cgit