1 files changed, 25 insertions, 16 deletions

diff --git a/src/tftp.rs b/src/tftp.rs
index 72bac22..e99dcf0 100644
--- a/src/tftp.rs
+++ b/src/tftp.rs
@@ -32,15 +32,24 @@ pub enum TftpOp {
     Oack,
 }
 
-impl Into<u16> for TftpOp {
-    fn into(self) -> u16 {
-        match self {
-            TftpOp::ReadRequest => 1,
-            TftpOp::WriteRequest => 2,
-            TftpOp::Data => 3,
-            TftpOp::Ack => 4,
-            TftpOp::Error => 5,
-            TftpOp::Oack => 6,
+impl TftpOp {
+    pub const CODE_READ_REQUEST: u16 = 1;
+    pub const CODE_WRITE_REQUEST: u16 = 2;
+    pub const CODE_DATA: u16 = 3;
+    pub const CODE_ACK: u16 = 4;
+    pub const CODE_ERROR: u16 = 5;
+    pub const CODE_OACK: u16 = 6;
+}
+
+impl From<TftpOp> for u16 {
+    fn from(value: TftpOp) -> Self {
+        match value {
+            TftpOp::ReadRequest => TftpOp::CODE_READ_REQUEST,
+            TftpOp::WriteRequest => TftpOp::CODE_WRITE_REQUEST,
+            TftpOp::Data => TftpOp::CODE_DATA,
+            TftpOp::Ack => TftpOp::CODE_ACK,
+            TftpOp::Error => TftpOp::CODE_ERROR,
+            TftpOp::Oack => TftpOp::CODE_OACK,
         }
     }
 }
@@ -50,12 +59,12 @@ impl TryFrom<u16> for TftpOp {
 
     fn try_from(value: u16) -> std::result::Result<Self, InvalidTftpOp> {
         match value {
-            1 => Ok(Self::ReadRequest),
-            2 => Ok(Self::WriteRequest),
-            3 => Ok(Self::Data),
-            4 => Ok(Self::Ack),
-            5 => Ok(Self::Error),
-            6 => Ok(Self::Oack),
+            Self::CODE_READ_REQUEST => Ok(Self::ReadRequest),
+            Self::CODE_WRITE_REQUEST => Ok(Self::WriteRequest),
+            Self::CODE_DATA => Ok(Self::Data),
+            Self::CODE_ACK => Ok(Self::Ack),
+            Self::CODE_ERROR => Ok(Self::Error),
+            Self::CODE_OACK => Ok(Self::Oack),
             unknown => Err(InvalidTftpOp(unknown)),
         }
     }
@@ -126,7 +135,7 @@ pub struct TftpReadRequestPacket {
 }
 
 impl TftpReadRequestPacket {
-    pub fn write<W: Write>(&self, mut writer: W) -> Result<()> {
+    pub fn write<W: Write>(&self, _writer: W) -> Result<()> {
         todo!()
     }
 }