fixed docker repeated docker pull

1 files changed, 10 insertions, 2 deletions

diff --git a/src/main.rs b/src/main.rs
index 8e8e5ea..b964d95 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -496,14 +496,22 @@ async fn cmd_clean(args: CleanArgs) -> Result<()> {
 }
 
 fn machine_containers_create_script(containers: &[ScheduledContainer]) -> String {
+    let images = containers
+        .iter()
+        .map(|c| c.image.clone())
+        .collect::<HashSet<_>>();
+
     let mut script = String::default();
+
+    for image in images {
+        script.push_str(&format!("docker pull {} || exit 1\n", image));
+    }
+
     for (idx, container) in containers.iter().enumerate() {
         // remove the start signal file if it exists
         script.push_str("mkdir -p /tmp/oar-p2p-signal\n");
         script.push_str("rm /tmp/oar-p2p-signal/start 2>/dev/null || true\n");
 
-        script.push_str(&format!("docker pull {} || exit 1\n", container.image));
-
         script.push_str("docker create \\\n");
         script.push_str("\t--pull=never \\\n");
         script.push_str("\t--network=host \\\n");