Merge branch 'main' into embassy-gitembassy-git

10 files changed, 115 insertions, 35 deletions

diff --git a/.claude/commands/release.md b/.claude/commands/release.md
new file mode 100644
index 0000000..c0f072e
--- /dev/null
+++ b/.claude/commands/release.md
@@ -0,0 +1,36 @@
+# Release Command
+
+Create a new cargo release for embassy-ha.
+
+## Instructions
+
+1. **Ask for the new version number** - Prompt the user for the version (e.g., "0.3.0"). Do not include the "v" prefix in the version number itself.
+
+2. **Verify clean working directory** - Run `git status --porcelain` and fail if there are any uncommitted changes. The working directory must be clean before proceeding.
+
+3. **Run pre-release checks** - Run the following commands in order. If any command fails, **stop immediately**, report the error, and let the user fix the issues manually. Do NOT attempt to fix issues automatically:
+   - `cargo fmt --check` - Verify code is properly formatted
+   - `cargo clippy` - Run linter (must have no warnings)
+   - `cargo check --tests --examples` - Check compilation of tests and examples
+   - `cargo test` - Run the test suite
+   - `cargo publish --dry-run` - Verify the package can be published
+
+4. **Update version in Cargo.toml** - Only after all pre-release checks pass, update the `version` field in `Cargo.toml` to the new version.
+
+5. **Create release commit** - Create a commit with the message: `chore: release v{version}`
+
+6. **Create tag** - Create an annotated tag with the name `v{version}` and message `v{version}`
+
+7. **Push to remote** - Push both the commit and the tag to the remote:
+   - `git push`
+   - `git push --tags`
+
+## Important Notes
+
+- If any pre-release check fails, **stop immediately** and report the failure. Do NOT:
+  - Attempt to fix the issues automatically (e.g., running `cargo fmt` to fix formatting)
+  - Update the version in Cargo.toml
+  - Create the commit or tag
+- The user is responsible for fixing any issues and re-running the release command
+- The tag format must be `v{version}` (e.g., `v0.3.0`) to match existing conventions
+- Use `--dry-run` for cargo publish to verify without actually publishing
diff --git a/Cargo.lock b/Cargo.lock
index fe3eb21..4574afe 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -175,7 +175,7 @@ source = "git+https://github.com/embassy-rs/embassy#dd4b0ae19e97101dab86af061e69
 
 [[package]]
 name = "embassy-ha"
-version = "0.2.0"
+version = "0.3.0"
 dependencies = [
  "critical-section",
  "defmt 1.0.1",
diff --git a/Cargo.toml b/Cargo.toml
index 5821533..62a777c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "embassy-ha"
-version = "0.2.0"
+version = "0.3.0"
 edition = "2024"
 authors = ["diogo464 <[email protected]>"]
 description = "MQTT Home Assistant integration library for Embassy async runtime"
diff --git a/release.sh b/release.sh
new file mode 100755
index 0000000..e79aa17
--- /dev/null
+++ b/release.sh
@@ -0,0 +1,59 @@
+#!/bin/bash
+set -euo pipefail
+
+VERSION="${1:-}"
+
+if [[ -z "$VERSION" ]]; then
+    echo "Usage: $0 <version>"
+    echo "Example: $0 0.3.0"
+    exit 1
+fi
+
+if [[ ! "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
+    echo "Error: Version must be in format x.y.z"
+    exit 1
+fi
+
+echo "Releasing version $VERSION"
+
+# Verify clean working directory
+if [[ -n "$(git status --porcelain)" ]]; then
+    echo "Error: Working directory has uncommitted changes"
+    git status --short
+    exit 1
+fi
+
+echo "Running pre-release checks..."
+
+echo "  cargo fmt --check"
+cargo fmt --check
+
+echo "  cargo clippy"
+cargo clippy -- -D warnings
+
+echo "  cargo check --tests --examples"
+cargo check --tests --examples
+
+echo "  cargo test"
+cargo test
+
+echo "  cargo publish --dry-run"
+cargo publish --dry-run
+
+echo "All checks passed. Updating version..."
+
+sed -i "s/^version = \".*\"/version = \"$VERSION\"/" Cargo.toml
+
+echo "Creating commit..."
+git add Cargo.toml
+git commit -m "chore: release v$VERSION"
+
+echo "Creating tag..."
+git tag -a "v$VERSION" -m "v$VERSION"
+
+echo "Pushing to remote..."
+git push
+git push --tags
+
+echo "Release v$VERSION complete!"
+echo "To publish to crates.io, run: cargo publish"
diff --git a/src/command_policy.rs b/src/command_policy.rs
index e5859bb..a1bb3bf 100644
--- a/src/command_policy.rs
+++ b/src/command_policy.rs
@@ -63,8 +63,7 @@
 /// # }
 /// # async fn turn_on_motor() -> Result<(), ()> { Ok(()) }
 /// ```
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-#[derive(Default)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 pub enum CommandPolicy {
     /// Automatically publish the entity's state when a command is received.
     #[default]
@@ -73,4 +72,3 @@ pub enum CommandPolicy {
     /// Do not automatically publish state. The application must manually update the state.
     Manual,
 }
-
diff --git a/src/entity_sensor.rs b/src/entity_sensor.rs
index e221141..fd5e7f7 100644
--- a/src/entity_sensor.rs
+++ b/src/entity_sensor.rs
@@ -18,8 +18,7 @@ impl StateClass {
     }
 }
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-#[derive(Default)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 pub enum SensorClass {
     #[default]
     Generic,
@@ -77,7 +76,6 @@ pub enum SensorClass {
     Other(&'static str),
 }
 
-
 impl SensorClass {
     pub fn as_str(&self) -> Option<&'static str> {
         match self {
diff --git a/src/entity_switch.rs b/src/entity_switch.rs
index 2b799a1..b685ce5 100644
--- a/src/entity_switch.rs
+++ b/src/entity_switch.rs
@@ -14,15 +14,13 @@ pub enum SwitchClass {
 /// Configuration for a switch entity.
 ///
 /// See [`CommandPolicy`] for details on how commands are handled.
-#[derive(Debug)]
-#[derive(Default)]
+#[derive(Debug, Default)]
 pub struct SwitchConfig {
     pub common: EntityCommonConfig,
     pub class: SwitchClass,
     pub command_policy: CommandPolicy,
 }
 
-
 impl SwitchConfig {
     pub(crate) fn populate(&self, config: &mut EntityConfig) {
         self.common.populate(config);
diff --git a/src/lib.rs b/src/lib.rs
index 2d1ecfb..35d50ca 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -346,6 +346,7 @@ pub struct DeviceConfig {
     pub model: &'static str,
 }
 
+#[derive(Default)]
 pub struct DeviceBuffersOwned {
     pub publish: Vec<u8, 2048>,
     pub subscribe: Vec<u8, 128>,
@@ -357,21 +358,6 @@ pub struct DeviceBuffersOwned {
     pub attributes_topic: String<128>,
 }
 
-impl Default for DeviceBuffersOwned {
-    fn default() -> Self {
-        Self {
-            publish: Default::default(),
-            subscribe: Default::default(),
-            discovery: Default::default(),
-            availability_topic: Default::default(),
-            discovery_topic: Default::default(),
-            state_topic: Default::default(),
-            command_topic: Default::default(),
-            attributes_topic: Default::default(),
-        }
-    }
-}
-
 impl DeviceBuffersOwned {
     pub fn as_buffers_mut(&mut self) -> DeviceBuffers<'_> {
         DeviceBuffers {
@@ -1093,10 +1079,8 @@ fn generate_entity_discovery(
 ///
 /// ```no_run
 /// # use embassy_ha::{Device, Transport};
-/// # async fn example(mut device: Device<'_>, create_transport: impl Fn() -> impl Transport) {
+/// # async fn example(mut device: Device<'_>, mut transport: impl Transport) {
 /// loop {
-///     let mut transport = create_transport();
-///
 ///     match embassy_ha::run(&mut device, &mut transport).await {
 ///         Ok(()) => {
 ///             // Normal exit (this shouldn't happen in practice)
diff --git a/src/mqtt/rx.rs b/src/mqtt/rx.rs
index 10b775a..0dfd858 100644
--- a/src/mqtt/rx.rs
+++ b/src/mqtt/rx.rs
@@ -37,7 +37,9 @@ impl From<varint::Error> for Error {
     fn from(value: varint::Error) -> Self {
         match value {
             varint::Error::NeedMoreData => Self::NeedMoreData,
-            varint::Error::InvalidVarInt => Self::InvalidPacket("invalid variable integer encoding"),
+            varint::Error::InvalidVarInt => {
+                Self::InvalidPacket("invalid variable integer encoding")
+            }
         }
     }
 }
@@ -92,8 +94,10 @@ pub fn decode<'a>(buf: &'a [u8]) -> Result<(Packet<'a>, usize), Error> {
         protocol::PACKET_TYPE_PUBLISH => {
             // Extract flags from the fixed header
             let retain = (packet_flags & protocol::PUBLISH_FLAG_RETAIN) != 0;
-            let qos_value = (packet_flags & protocol::PUBLISH_FLAG_QOS_MASK) >> protocol::PUBLISH_FLAG_QOS_SHIFT;
-            let qos = Qos::from_u8(qos_value).ok_or(Error::InvalidPacket("PUBLISH has invalid QoS value"))?;
+            let qos_value = (packet_flags & protocol::PUBLISH_FLAG_QOS_MASK)
+                >> protocol::PUBLISH_FLAG_QOS_SHIFT;
+            let qos = Qos::from_u8(qos_value)
+                .ok_or(Error::InvalidPacket("PUBLISH has invalid QoS value"))?;
             let dup = (packet_flags & protocol::PUBLISH_FLAG_DUP) != 0;
 
             // Track position after fixed header to calculate data length
@@ -113,7 +117,9 @@ pub fn decode<'a>(buf: &'a [u8]) -> Result<(Packet<'a>, usize), Error> {
             let variable_header_len = reader.num_read() - variable_header_start;
             let data_len = (packet_len as usize)
                 .checked_sub(variable_header_len)
-                .ok_or(Error::InvalidPacket("PUBLISH remaining length is too short for headers"))?;
+                .ok_or(Error::InvalidPacket(
+                    "PUBLISH remaining length is too short for headers",
+                ))?;
 
             Packet::Publish {
                 topic,
@@ -140,7 +146,9 @@ pub fn decode<'a>(buf: &'a [u8]) -> Result<(Packet<'a>, usize), Error> {
             }
             if packet_len < 3 {
                 // Minimum: 2 bytes packet ID + 1 byte return code
-                return Err(Error::InvalidPacket("SUBACK remaining length must be at least 3"));
+                return Err(Error::InvalidPacket(
+                    "SUBACK remaining length must be at least 3",
+                ));
             }
             let packet_id = PacketId::from(reader.read_u16()?);
             let return_code = reader.read_u8()?;
diff --git a/src/mqtt/tx.rs b/src/mqtt/tx.rs
index 7a4d443..3b2ed66 100644
--- a/src/mqtt/tx.rs
+++ b/src/mqtt/tx.rs
@@ -209,4 +209,3 @@ pub fn pingreq(buffer: &mut FieldBuffer) {
     )));
     buffer.push(Field::VarInt(0));
 }
-