diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2022-02-10 15:15:06 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2022-02-10 15:15:06 +0000 |
| commit | 9d682aa1fae81d9bb56bb41304828144b9a0d4a7 (patch) | |
| tree | fda3c3af254733ecd9e1804b79383b648ccd806f /.github/workflows | |
| parent | 1d265b73b2f46baf60a481c8b8036e50c2b6583f (diff) | |
| parent | a8bd3ab9521fc2c3c4a409c40648068af3d63d97 (diff) | |
Merge #605
605: stm32: Remove OptionalPin r=Dirbaio a=Dirbaio
The idea behind OptionalPin has a few problems:
- you need to impl the signal traits for NoPin which is a bit weird https://github.com/embassy-rs/embassy/blob/master/embassy-stm32/src/dcmi.rs#L413-L416
- you can pass any combination of set/unset pins, which needs checking at runtime https://github.com/embassy-rs/embassy/blob/master/embassy-stm32/src/dcmi.rs#L130
The replacement is to do multiple `new` constructors for each combination of pins you want to take.
Co-authored-by: Dario Nieuwenhuis <[email protected]>
Diffstat (limited to '.github/workflows')
0 files changed, 0 insertions, 0 deletions