diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-11-26 23:08:24 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-11-26 23:08:24 +0000 |
| commit | c7d97290284d2637c1eb89f65ff18f913342a71b (patch) | |
| tree | bbe78c9b8f3e198dda88ebc7072c077cacfad488 /.vscode | |
| parent | 524eed5db57c73fe06777283f5992bc514f8fc50 (diff) | |
| parent | 4010a829aef42dd7aec5bdf967675119f2fa0857 (diff) | |
Merge #486
486: Pwm ppi events r=Dirbaio a=jacobrosenthal
More PWM yak shaving. I was going to do some safe pwm ppi events stuff but I just dont think it fits this api design.. ppi is just very low level, im not sure how safe it will be in general
* first we should probably have borrows of handlers for ppi with lifetime of the peripheral? hal does https://github.com/nrf-rs/nrf-hal/blob/eb4ba6ae4204c7f58fc968e57b2995df15f5ac77/nrf-hal-common/src/pwm.rs#L714-L716
* in general having access to tasks can put the state in some configuration the api doesnt understand anymore. for `SequencePwm` ideally id hand you back either only seq_start0 or seq_start1 because youd only use one based on if your `Times` is even or odd.. but again we only know that with this api AFTER start has been called. I dont think were ready for typestates
SO I figured why not add the pwm ppi events but make them unsafe and commit this example since I started it.
Somewhat related drop IS removing the last duty cycle from the pin correctly, but stop DOES NOT..the only thing that sets the pin back is pin.conf() as far as I can tell, so I tried to document that better and got rid of stop for the `SimplePwm` again since that doesnt need it then. However its ackward we dont have a way to unset the pwm without setting a new sequence of 0s, or dropping the peripheral
Co-authored-by: Jacob Rosenthal <[email protected]>
Diffstat (limited to '.vscode')
0 files changed, 0 insertions, 0 deletions