chore: clean up transfer options

3 files changed, 6 insertions, 36 deletions

diff --git a/embassy-stm32/src/dma/gpdma/linked_list.rs b/embassy-stm32/src/dma/gpdma/linked_list.rs
index b0c0dffad..b0cf96f96 100644
--- a/embassy-stm32/src/dma/gpdma/linked_list.rs
+++ b/embassy-stm32/src/dma/gpdma/linked_list.rs
@@ -4,7 +4,6 @@
 use stm32_metapac::gpdma::regs;
 use stm32_metapac::gpdma::vals::Dreq;
 
-use super::TransferOptions;
 use crate::dma::word::{Word, WordSize};
 use crate::dma::{Dir, Request};
 
@@ -42,12 +41,7 @@ pub struct LinearItem {
 
 impl LinearItem {
     /// Create a new read DMA transfer (peripheral to memory).
-    pub unsafe fn new_read<'d, W: Word>(
-        request: Request,
-        peri_addr: *mut W,
-        buf: &'d mut [W],
-        options: TransferOptions,
-    ) -> Self {
+    pub unsafe fn new_read<'d, W: Word>(request: Request, peri_addr: *mut W, buf: &'d mut [W]) -> Self {
         Self::new_inner(
             request,
             Dir::PeripheralToMemory,
@@ -57,17 +51,11 @@ impl LinearItem {
             true,
             W::size(),
             W::size(),
-            options,
         )
     }
 
     /// Create a new write DMA transfer (memory to peripheral).
-    pub unsafe fn new_write<'d, MW: Word, PW: Word>(
-        request: Request,
-        buf: &'d [MW],
-        peri_addr: *mut PW,
-        options: TransferOptions,
-    ) -> Self {
+    pub unsafe fn new_write<'d, MW: Word, PW: Word>(request: Request, buf: &'d [MW], peri_addr: *mut PW) -> Self {
         Self::new_inner(
             request,
             Dir::MemoryToPeripheral,
@@ -77,7 +65,6 @@ impl LinearItem {
             true,
             MW::size(),
             PW::size(),
-            options,
         )
     }
 
@@ -90,7 +77,6 @@ impl LinearItem {
         incr_mem: bool,
         data_size: WordSize,
         dst_size: WordSize,
-        _options: TransferOptions,
     ) -> Self {
         // BNDT is specified as bytes, not as number of transfers.
         let Ok(bndt) = (mem_len * data_size.bytes()).try_into() else {
diff --git a/embassy-stm32/src/dma/gpdma/mod.rs b/embassy-stm32/src/dma/gpdma/mod.rs
index b23c22dfb..e906c7559 100644
--- a/embassy-stm32/src/dma/gpdma/mod.rs
+++ b/embassy-stm32/src/dma/gpdma/mod.rs
@@ -284,8 +284,6 @@ impl AnyChannel {
     }
 
     /// Configure a linked-list transfer.
-    ///
-    /// Transfer options apply only to the base register transfer, not the linked-list items.
     unsafe fn configure_linked_list<const ITEM_COUNT: usize>(
         &self,
         table: &Table<ITEM_COUNT>,
diff --git a/embassy-stm32/src/dma/gpdma/ringbuffered.rs b/embassy-stm32/src/dma/gpdma/ringbuffered.rs
index a5b127d08..9bee12d99 100644
--- a/embassy-stm32/src/dma/gpdma/ringbuffered.rs
+++ b/embassy-stm32/src/dma/gpdma/ringbuffered.rs
@@ -222,14 +222,12 @@ pub struct WritableRingBuffer<'a, W: Word> {
 
 impl<'a, W: Word> WritableRingBuffer<'a, W> {
     /// Create a new ring buffer.
-    ///
-    /// Transfer options are applied to the individual linked list items.
     pub unsafe fn new(
         channel: impl Peripheral<P = impl Channel> + 'a,
         request: Request,
         peri_addr: *mut W,
         buffer: &'a mut [W],
-        mut options: TransferOptions,
+        _options: TransferOptions,
     ) -> Self {
         into_ref!(channel);
         let channel: PeripheralRef<'a, AnyChannel> = channel.map_into();
@@ -237,12 +235,9 @@ impl<'a, W: Word> WritableRingBuffer<'a, W> {
         let half_len = buffer.len() / 2;
         assert_eq!(half_len * 2, buffer.len());
 
-        options.half_transfer_ir = false;
-        options.complete_transfer_ir = true;
-
         let items = [
-            LinearItem::new_write(request, &mut buffer[..half_len], peri_addr, options),
-            LinearItem::new_write(request, &mut buffer[half_len..], peri_addr, options),
+            LinearItem::new_write(request, &mut buffer[..half_len], peri_addr),
+            LinearItem::new_write(request, &mut buffer[half_len..], peri_addr),
         ];
         let table = Table::new(items);
 
@@ -279,16 +274,7 @@ impl<'a, W: Word> WritableRingBuffer<'a, W> {
     ///
     /// You must call this after creating it for it to work.
     pub fn start(&mut self) {
-        unsafe {
-            self.channel.configure_linked_list(
-                &self.table,
-                TransferOptions {
-                    half_transfer_ir: false,
-                    complete_transfer_ir: true,
-                    ..Default::default()
-                },
-            )
-        };
+        unsafe { self.channel.configure_linked_list(&self.table, Default::default()) };
         self.table.link(RunMode::Repeat);
         self.channel.start();
     }