embassy: Clippy fixes.

4 files changed, 19 insertions, 7 deletions

diff --git a/embassy/src/channel/pubsub/mod.rs b/embassy/src/channel/pubsub/mod.rs
index 11c889368..64a72a52c 100644
--- a/embassy/src/channel/pubsub/mod.rs
+++ b/embassy/src/channel/pubsub/mod.rs
@@ -104,7 +104,7 @@ impl<M: RawMutex, T: Clone, const CAP: usize, const SUBS: usize, const PUBS: usi
     /// Create a new subscriber. It will only receive messages that are published after its creation.
     ///
     /// If there are no subscriber slots left, an error will be returned.
-    pub fn dyn_subscriber<'a>(&'a self) -> Result<DynSubscriber<'a, T>, Error> {
+    pub fn dyn_subscriber(&self) -> Result<DynSubscriber<'_, T>, Error> {
         self.inner.lock(|inner| {
             let mut s = inner.borrow_mut();
 
@@ -136,7 +136,7 @@ impl<M: RawMutex, T: Clone, const CAP: usize, const SUBS: usize, const PUBS: usi
     /// Create a new publisher
     ///
     /// If there are no publisher slots left, an error will be returned.
-    pub fn dyn_publisher<'a>(&'a self) -> Result<DynPublisher<'a, T>, Error> {
+    pub fn dyn_publisher(&self) -> Result<DynPublisher<'_, T>, Error> {
         self.inner.lock(|inner| {
             let mut s = inner.borrow_mut();
 
@@ -369,7 +369,7 @@ impl<T: Clone, const CAP: usize, const SUBS: usize, const PUBS: usize> PubSubSta
 }
 
 /// Error type for the [PubSubChannel]
-#[derive(Debug, PartialEq, Clone)]
+#[derive(Debug, PartialEq, Eq, Clone)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum Error {
     /// All subscriber slots are used. To add another subscriber, first another subscriber must be dropped or
@@ -404,7 +404,7 @@ pub trait PubSubBehavior<T> {
 }
 
 /// The result of the subscriber wait procedure
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum WaitResult<T> {
     /// The subscriber did not receive all messages and lagged by the given amount of messages.
diff --git a/embassy/src/executor/raw/mod.rs b/embassy/src/executor/raw/mod.rs
index b8455442e..7e8559168 100644
--- a/embassy/src/executor/raw/mod.rs
+++ b/embassy/src/executor/raw/mod.rs
@@ -445,6 +445,10 @@ impl Executor {
 /// Wake a task by raw pointer.
 ///
 /// You can obtain task pointers from `Waker`s using [`task_from_waker`].
+///
+/// # Safety
+///
+/// `task` must be a valid task pointer obtained from [`task_from_waker`].
 pub unsafe fn wake_task(task: NonNull<TaskHeader>) {
     task.as_ref().enqueue();
 }
diff --git a/embassy/src/executor/spawner.rs b/embassy/src/executor/spawner.rs
index 884db6b55..c8d036eb8 100644
--- a/embassy/src/executor/spawner.rs
+++ b/embassy/src/executor/spawner.rs
@@ -93,7 +93,7 @@ impl Spawner {
     pub async fn for_current_executor() -> Self {
         poll_fn(|cx| unsafe {
             let task = raw::task_from_waker(cx.waker());
-            let executor = (&*task.as_ptr()).executor.get();
+            let executor = (*task.as_ptr()).executor.get();
             Poll::Ready(Self::new(&*executor))
         })
         .await
@@ -169,7 +169,7 @@ impl SendSpawner {
     pub async fn for_current_executor() -> Self {
         poll_fn(|cx| unsafe {
             let task = raw::task_from_waker(cx.waker());
-            let executor = (&*task.as_ptr()).executor.get();
+            let executor = (*task.as_ptr()).executor.get();
             Poll::Ready(Self::new(&*executor))
         })
         .await
diff --git a/embassy/src/util/forever.rs b/embassy/src/util/forever.rs
index e367d2643..0e0fee596 100644
--- a/embassy/src/util/forever.rs
+++ b/embassy/src/util/forever.rs
@@ -82,9 +82,17 @@ impl<T> Forever<T> {
         }
     }
 
+    /// Unsafely get a mutable reference to the contents of this Forever.
+    ///
+    /// # Safety
+    ///
+    /// This is undefined behavior if:
+    ///
+    /// - The `Forever` has not been initialized yet (with `put' or `put_with`), or
+    /// - A reference to the contents (mutable or not) already exists.
     #[inline(always)]
     #[allow(clippy::mut_from_ref)]
-    pub unsafe fn steal(&'static self) -> &'static mut T {
+    pub unsafe fn steal(&self) -> &mut T {
         let p = self.t.get();
         let p = (&mut *p).as_mut_ptr();
         &mut *p