aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Rosenthal <[email protected]>2021-11-03 18:46:42 -0700
committerJacob Rosenthal <[email protected]>2021-11-03 18:46:42 -0700
commit64e1426b54c41a5b622c666cd7763bb07f73a2c4 (patch)
tree47d1a94684219b7ee08740e20b4ade05445eb8b2
parentb726ef1886c65ab76b01f2c54ad559573e19083d (diff)
clean up some todo comments around infinite play
-rw-r--r--embassy-nrf/src/pwm.rs2
1 files changed, 0 insertions, 2 deletions
diff --git a/embassy-nrf/src/pwm.rs b/embassy-nrf/src/pwm.rs
index 9f88633c4..b0acd83c1 100644
--- a/embassy-nrf/src/pwm.rs
+++ b/embassy-nrf/src/pwm.rs
@@ -146,7 +146,6 @@ impl<'d, T: Instance> SequencePwm<'d, T> {
146 r.enable.write(|w| w.enable().enabled()); 146 r.enable.write(|w| w.enable().enabled());
147 147
148 match times { 148 match times {
149 // todo why doesn't this play forever? set_duty does...
150 // just the one time, no loop count 149 // just the one time, no loop count
151 SequenceMode::Times(1) => { 150 SequenceMode::Times(1) => {
152 r.loop_.write(|w| w.cnt().disabled()); 151 r.loop_.write(|w| w.cnt().disabled());
@@ -400,7 +399,6 @@ impl<'d, T: Instance> SimplePwm<'d, T> {
400 // todo justify? should i fence elsehwere we task start? or 399 // todo justify? should i fence elsehwere we task start? or
401 compiler_fence(Ordering::SeqCst); 400 compiler_fence(Ordering::SeqCst);
402 401
403 // todo why does this play forever when times(1) doesn't?
404 // tasks_seqstart() doesn't exist in all svds so write its bit instead 402 // tasks_seqstart() doesn't exist in all svds so write its bit instead
405 r.tasks_seqstart[0].write(|w| unsafe { w.bits(1) }); 403 r.tasks_seqstart[0].write(|w| unsafe { w.bits(1) });
406 } 404 }