diff options
| author | Mathias Koch <[email protected]> | 2022-09-15 05:38:55 +0200 |
|---|---|---|
| committer | Dario Nieuwenhuis <[email protected]> | 2022-09-27 22:08:49 +0200 |
| commit | b0d91e9f310f86b4eb9d75c92471831f1656ed1b (patch) | |
| tree | de075c20fd90d238ea1cc53f162ff241d59dbca6 | |
| parent | 53c34ccc399c7bec98880657e52842477af09f49 (diff) | |
Apply suggestions from code review
Co-authored-by: Jacob Gonzalez <[email protected]>
| -rw-r--r-- | embassy-rp/src/i2c.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/embassy-rp/src/i2c.rs b/embassy-rp/src/i2c.rs index 19cdef133..12fae3b7b 100644 --- a/embassy-rp/src/i2c.rs +++ b/embassy-rp/src/i2c.rs | |||
| @@ -144,7 +144,7 @@ impl<'d, T: Instance> I2c<'d, T, Async> { | |||
| 144 | let len = buffer.len(); | 144 | let len = buffer.len(); |
| 145 | self.read_blocking_internal(&mut buffer[..1], true, len == 1)?; | 145 | self.read_blocking_internal(&mut buffer[..1], true, len == 1)?; |
| 146 | 146 | ||
| 147 | if len > 2 { | 147 | if len >= 2 { |
| 148 | // Note(safety): Unwrap should be safe, as this can only be called | 148 | // Note(safety): Unwrap should be safe, as this can only be called |
| 149 | // when `Mode == Async`, where we have dma channels. | 149 | // when `Mode == Async`, where we have dma channels. |
| 150 | let ch = self.rx_dma.as_mut().unwrap(); | 150 | let ch = self.rx_dma.as_mut().unwrap(); |
| @@ -168,7 +168,7 @@ impl<'d, T: Instance> I2c<'d, T, Async> { | |||
| 168 | transfer.await; | 168 | transfer.await; |
| 169 | } | 169 | } |
| 170 | 170 | ||
| 171 | if len > 2 { | 171 | if len >= 2 { |
| 172 | self.read_blocking_internal(&mut buffer[len - 1..], false, true)?; | 172 | self.read_blocking_internal(&mut buffer[len - 1..], false, true)?; |
| 173 | } | 173 | } |
| 174 | 174 | ||
| @@ -202,7 +202,7 @@ impl<'d, T: Instance> I2c<'d, T, Async> { | |||
| 202 | if bytes.is_empty() { | 202 | if bytes.is_empty() { |
| 203 | self.write_blocking_internal(bytes, false)?; | 203 | self.write_blocking_internal(bytes, false)?; |
| 204 | } else { | 204 | } else { |
| 205 | self.write_internal(bytes, false).await?; | 205 | self.write_internal(bytes, true).await?; |
| 206 | } | 206 | } |
| 207 | 207 | ||
| 208 | if buffer.is_empty() { | 208 | if buffer.is_empty() { |
