aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames Munns <[email protected]>2025-08-19 15:11:23 +0000
committerGitHub <[email protected]>2025-08-19 15:11:23 +0000
commitb5887b252ae2b8181de1948af2f2137d56bd9e76 (patch)
treebafaf5fd49a2543be9b0627b9582ac3d20de1e35
parent6433d7bf397b8cb28941c5ba3d07ac097852b565 (diff)
parent52464b35367f14797bf2757432163fa9dccc2361 (diff)
Merge pull request #4567 from vDorst/i2c-pull-down-fix
stm32/i2c: Pull-down enabled when non-pull was requested.
-rw-r--r--embassy-stm32/CHANGELOG.md1
-rw-r--r--embassy-stm32/src/i2c/config.rs4
2 files changed, 3 insertions, 2 deletions
diff --git a/embassy-stm32/CHANGELOG.md b/embassy-stm32/CHANGELOG.md
index d2dccaea5..301c20055 100644
--- a/embassy-stm32/CHANGELOG.md
+++ b/embassy-stm32/CHANGELOG.md
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
8<!-- next-header --> 8<!-- next-header -->
9## Unreleased - ReleaseDate 9## Unreleased - ReleaseDate
10 10
11- fix: stm32/i2c: pull-down was enabled instead of pull-none when no internal pull-up was needed.
11- feat: Improve blocking hash speed 12- feat: Improve blocking hash speed
12- fix: Fix vrefbuf building with log feature 13- fix: Fix vrefbuf building with log feature
13- fix: Fix performing a hash after performing a hmac 14- fix: Fix performing a hash after performing a hmac
diff --git a/embassy-stm32/src/i2c/config.rs b/embassy-stm32/src/i2c/config.rs
index b27bb778c..4e3b736c7 100644
--- a/embassy-stm32/src/i2c/config.rs
+++ b/embassy-stm32/src/i2c/config.rs
@@ -156,7 +156,7 @@ impl Config {
156 self.gpio_speed, 156 self.gpio_speed,
157 match self.scl_pullup { 157 match self.scl_pullup {
158 true => Pull::Up, 158 true => Pull::Up,
159 false => Pull::Down, 159 false => Pull::None,
160 }, 160 },
161 ); 161 );
162 } 162 }
@@ -170,7 +170,7 @@ impl Config {
170 self.gpio_speed, 170 self.gpio_speed,
171 match self.sda_pullup { 171 match self.sda_pullup {
172 true => Pull::Up, 172 true => Pull::Up,
173 false => Pull::Down, 173 false => Pull::None,
174 }, 174 },
175 ); 175 );
176 } 176 }