aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2022-11-21 22:08:46 +0000
committerGitHub <[email protected]>2022-11-21 22:08:46 +0000
commitbbfb7861390ac00d9a54d6f0f1ed41e74ed4a86d (patch)
tree78748564dfc84f36e700c5245c9bd6df5ad3d6d6
parent2528f451387e6c7b27c3140cd87d47521d1971a2 (diff)
parent81dc532d2d041466f2e815f5b9e97a856c47073c (diff)
Merge #1064
1064: Fix LoRaWAN PHY settings for SX126x driver r=Dirbaio a=jbeaurivage While working on #1023 / #1041, I noticed that the `lorawan_device::PhyTxRx` implementation does not conform to the LoRaWAN standard, and therefore devices using this driver could never communicate with a gateway. This PR backports the changes I've made to fix the offending parameters, and I can confirm that the driver now works with LoRaWAN networks. * Set preamble length to 8 symbols * Set polarity to inverted for received messages Co-authored-by: Justin Beaurivage <[email protected]>
-rw-r--r--embassy-lora/src/sx126x/mod.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/embassy-lora/src/sx126x/mod.rs b/embassy-lora/src/sx126x/mod.rs
index ed8cb4059..b14d422a7 100644
--- a/embassy-lora/src/sx126x/mod.rs
+++ b/embassy-lora/src/sx126x/mod.rs
@@ -87,7 +87,7 @@ where
87 config.rf.spreading_factor.into(), 87 config.rf.spreading_factor.into(),
88 config.rf.bandwidth.into(), 88 config.rf.bandwidth.into(),
89 config.rf.coding_rate.into(), 89 config.rf.coding_rate.into(),
90 4, 90 8,
91 false, 91 false,
92 true, 92 true,
93 false, 93 false,
@@ -119,14 +119,14 @@ where
119 config.spreading_factor.into(), 119 config.spreading_factor.into(),
120 config.bandwidth.into(), 120 config.bandwidth.into(),
121 config.coding_rate.into(), 121 config.coding_rate.into(),
122 4, 122 8,
123 4, 123 4,
124 false, 124 false,
125 0u8, 125 0u8,
126 true, 126 true,
127 false, 127 false,
128 0, 128 0,
129 false, 129 true,
130 true, 130 true,
131 ) 131 )
132 .await?; 132 .await?;