Merge branch 'embassy-rs:main' into multi-signal

2 files changed, 25 insertions, 15 deletions

diff --git a/embassy-executor/src/raw/mod.rs b/embassy-executor/src/raw/mod.rs
index 3d5e3ab9f..d9ea5c005 100644
--- a/embassy-executor/src/raw/mod.rs
+++ b/embassy-executor/src/raw/mod.rs
@@ -30,7 +30,7 @@ use core::ptr::NonNull;
 use core::task::{Context, Poll};
 
 #[cfg(feature = "integrated-timers")]
-use embassy_time_driver::{self, AlarmHandle};
+use embassy_time_driver::AlarmHandle;
 #[cfg(feature = "rtos-trace")]
 use rtos_trace::trace;
 
diff --git a/embassy-executor/src/raw/waker.rs b/embassy-executor/src/raw/waker.rs
index 522853e34..8bb2cfd05 100644
--- a/embassy-executor/src/raw/waker.rs
+++ b/embassy-executor/src/raw/waker.rs
@@ -1,4 +1,3 @@
-use core::mem;
 use core::task::{RawWaker, RawWakerVTable, Waker};
 
 use super::{wake_task, TaskHeader, TaskRef};
@@ -33,20 +32,31 @@ pub(crate) unsafe fn from_task(p: TaskRef) -> Waker {
 ///
 /// Panics if the waker is not created by the Embassy executor.
 pub fn task_from_waker(waker: &Waker) -> TaskRef {
-    // safety: OK because WakerHack has the same layout as Waker.
-    // This is not really guaranteed because the structs are `repr(Rust)`, it is
-    // indeed the case in the current implementation.
-    // TODO use waker_getters when stable. https://github.com/rust-lang/rust/issues/96992
-    let hack: &WakerHack = unsafe { mem::transmute(waker) };
-    if hack.vtable != &VTABLE {
+    let (vtable, data) = {
+        #[cfg(not(feature = "nightly"))]
+        {
+            struct WakerHack {
+                data: *const (),
+                vtable: &'static RawWakerVTable,
+            }
+
+            // safety: OK because WakerHack has the same layout as Waker.
+            // This is not really guaranteed because the structs are `repr(Rust)`, it is
+            // indeed the case in the current implementation.
+            // TODO use waker_getters when stable. https://github.com/rust-lang/rust/issues/96992
+            let hack: &WakerHack = unsafe { core::mem::transmute(waker) };
+            (hack.vtable, hack.data)
+        }
+
+        #[cfg(feature = "nightly")]
+        {
+            (waker.vtable(), waker.data())
+        }
+    };
+
+    if vtable != &VTABLE {
         panic!("Found waker not created by the Embassy executor. `embassy_time::Timer` only works with the Embassy executor.")
     }
-
     // safety: our wakers are always created with `TaskRef::as_ptr`
-    unsafe { TaskRef::from_ptr(hack.data as *const TaskHeader) }
-}
-
-struct WakerHack {
-    data: *const (),
-    vtable: &'static RawWakerVTable,
+    unsafe { TaskRef::from_ptr(data as *const TaskHeader) }
 }