diff options
| author | Gerhard de Clercq <[email protected]> | 2025-05-13 15:09:53 +0200 |
|---|---|---|
| committer | Gerhard de Clercq <[email protected]> | 2025-05-13 15:13:46 +0200 |
| commit | 46e25cbc5ff62e24f86574d7ae5d872aa0c2595d (patch) | |
| tree | 2ddf612d681152dc87b2543aa2f7c4762154cc73 /embassy-usb-dfu | |
| parent | f7c796e3ccdbd559eee26fddf39413782530f977 (diff) | |
[embassy-usb-dfu] correct comment about composite devices
Diffstat (limited to 'embassy-usb-dfu')
| -rw-r--r-- | embassy-usb-dfu/src/application.rs | 5 | ||||
| -rw-r--r-- | embassy-usb-dfu/src/dfu.rs | 5 |
2 files changed, 6 insertions, 4 deletions
diff --git a/embassy-usb-dfu/src/application.rs b/embassy-usb-dfu/src/application.rs index 52a7ca951..2646d100d 100644 --- a/embassy-usb-dfu/src/application.rs +++ b/embassy-usb-dfu/src/application.rs | |||
| @@ -137,8 +137,9 @@ pub fn usb_dfu<'d, D: Driver<'d>, MARK: DfuMarker, RST: Reset>( | |||
| 137 | // We add MSOS headers so that the device automatically gets assigned the WinUSB driver on Windows. | 137 | // We add MSOS headers so that the device automatically gets assigned the WinUSB driver on Windows. |
| 138 | // Otherwise users need to do this manually using a tool like Zadig. | 138 | // Otherwise users need to do this manually using a tool like Zadig. |
| 139 | // | 139 | // |
| 140 | // Adding them here on the function level appears to only work for compositive devices though. | 140 | // Adding them here on the function level appears to only be needed for compositive devices. |
| 141 | // For non-composite devices they should be placed on the device level instead. | 141 | // In addition to being on the function level, they should also be added to the device level. |
| 142 | // | ||
| 142 | func.msos_feature(msos::CompatibleIdFeatureDescriptor::new("WINUSB", "")); | 143 | func.msos_feature(msos::CompatibleIdFeatureDescriptor::new("WINUSB", "")); |
| 143 | func.msos_feature(msos::RegistryPropertyFeatureDescriptor::new( | 144 | func.msos_feature(msos::RegistryPropertyFeatureDescriptor::new( |
| 144 | "DeviceInterfaceGUIDs", | 145 | "DeviceInterfaceGUIDs", |
diff --git a/embassy-usb-dfu/src/dfu.rs b/embassy-usb-dfu/src/dfu.rs index 83feacaf8..43a35637d 100644 --- a/embassy-usb-dfu/src/dfu.rs +++ b/embassy-usb-dfu/src/dfu.rs | |||
| @@ -193,8 +193,9 @@ pub fn usb_dfu<'d, D: Driver<'d>, DFU: NorFlash, STATE: NorFlash, RST: Reset, co | |||
| 193 | // We add MSOS headers so that the device automatically gets assigned the WinUSB driver on Windows. | 193 | // We add MSOS headers so that the device automatically gets assigned the WinUSB driver on Windows. |
| 194 | // Otherwise users need to do this manually using a tool like Zadig. | 194 | // Otherwise users need to do this manually using a tool like Zadig. |
| 195 | // | 195 | // |
| 196 | // Adding them here on the function level appears to only work for compositive devices though. | 196 | // Adding them here on the function level appears to only be needed for compositive devices. |
| 197 | // For non-composite devices they should be placed on the device level instead. | 197 | // In addition to being on the function level, they should also be added to the device level. |
| 198 | // | ||
| 198 | func.msos_feature(msos::CompatibleIdFeatureDescriptor::new("WINUSB", "")); | 199 | func.msos_feature(msos::CompatibleIdFeatureDescriptor::new("WINUSB", "")); |
| 199 | func.msos_feature(msos::RegistryPropertyFeatureDescriptor::new( | 200 | func.msos_feature(msos::RegistryPropertyFeatureDescriptor::new( |
| 200 | "DeviceInterfaceGUIDs", | 201 | "DeviceInterfaceGUIDs", |