diff options
| author | James Munns <[email protected]> | 2023-03-27 18:21:11 +0200 |
|---|---|---|
| committer | James Munns <[email protected]> | 2023-03-27 18:21:11 +0200 |
| commit | 20aa86d63e6967989ab4d70a638cfe8a0a62a2ca (patch) | |
| tree | 8adc89b98aedaeff06b581ac04cf7181ecaababa /embassy-usb | |
| parent | a77fdefd7c16cb6077d4f27ec5094e52457fcde5 (diff) | |
Address review comments
Diffstat (limited to 'embassy-usb')
| -rw-r--r-- | embassy-usb/src/builder.rs | 10 | ||||
| -rw-r--r-- | embassy-usb/src/class/hid.rs | 4 |
2 files changed, 3 insertions, 11 deletions
diff --git a/embassy-usb/src/builder.rs b/embassy-usb/src/builder.rs index cad1ecda9..6b68bcd7b 100644 --- a/embassy-usb/src/builder.rs +++ b/embassy-usb/src/builder.rs | |||
| @@ -207,15 +207,7 @@ impl<'d, D: Driver<'d>> Builder<'d, D> { | |||
| 207 | info!("USB: bos_descriptor used: {}", self.bos_descriptor.writer.position()); | 207 | info!("USB: bos_descriptor used: {}", self.bos_descriptor.writer.position()); |
| 208 | #[cfg(feature = "msos-descriptor")] | 208 | #[cfg(feature = "msos-descriptor")] |
| 209 | info!("USB: msos_descriptor used: {}", msos_descriptor.len()); | 209 | info!("USB: msos_descriptor used: {}", msos_descriptor.len()); |
| 210 | if self.control_buf.len() != self.config.max_packet_size_0.into() { | 210 | info!("USB: control_buf size: {}", self.control_buf.len()); |
| 211 | warn!( | ||
| 212 | "USB: Mismatch in control buf and max packet size! buf len: {}, max ep0 size: {}", | ||
| 213 | self.control_buf.len(), | ||
| 214 | self.config.max_packet_size_0, | ||
| 215 | ); | ||
| 216 | } else { | ||
| 217 | info!("USB: control_buf size: {}", self.control_buf.len()); | ||
| 218 | } | ||
| 219 | 211 | ||
| 220 | UsbDevice::build( | 212 | UsbDevice::build( |
| 221 | self.driver, | 213 | self.driver, |
diff --git a/embassy-usb/src/class/hid.rs b/embassy-usb/src/class/hid.rs index 597403427..03e4c1dbb 100644 --- a/embassy-usb/src/class/hid.rs +++ b/embassy-usb/src/class/hid.rs | |||
| @@ -458,8 +458,8 @@ impl<'d> Handler for Control<'d> { | |||
| 458 | return None; | 458 | return None; |
| 459 | } | 459 | } |
| 460 | 460 | ||
| 461 | // TODO(AJM): This uses a defmt-specific formatter that causes use of the `log` | 461 | // This uses a defmt-specific formatter that causes use of the `log` |
| 462 | // feature to fail to build | 462 | // feature to fail to build, so leave it defmt-specific for now. |
| 463 | #[cfg(feature = "defmt")] | 463 | #[cfg(feature = "defmt")] |
| 464 | trace!("HID control_out {:?} {=[u8]:x}", req, data); | 464 | trace!("HID control_out {:?} {=[u8]:x}", req, data); |
| 465 | match req.request { | 465 | match req.request { |
