3 files changed, 180 insertions, 86 deletions

diff --git a/embassy-nrf/src/pwm.rs b/embassy-nrf/src/pwm.rs
index 947cd873b..a59fddf74 100644
--- a/embassy-nrf/src/pwm.rs
+++ b/embassy-nrf/src/pwm.rs
@@ -54,47 +54,11 @@ pub struct Pwm<'d, T: Instance> {
     phantom: PhantomData<&'d mut T>,
 }
 
-#[derive(Debug, Eq, PartialEq, Clone, Copy)]
-pub enum SequenceMode {
-    /// Run sequence n Times total
-    Times(u16),
-    /// Repeat until `stop` is called.
-    Infinite,
-}
-
-/// Configure an infinite looping sequence for `simple_playback`
-pub struct SequenceConfig<'a> {
-    /// Selects up mode or up-and-down mode for the counter
-    pub counter_mode: CounterMode,
-    /// Top value to be compared against buffer values
-    pub top: u16,
-    /// Configuration for PWM_CLK
-    pub prescaler: Prescaler,
-    /// In ram buffer to be played back
-    pub sequence: &'a [u16],
-    /// How a sequence is read from RAM and is spread to the compare register
-    pub sequence_load: SequenceLoad,
-    /// Number of Times PWM periods to delay between each sequence sample
-    pub refresh: u32,
-    /// Number of Times PWM periods after the sequence ends before starting the next sequence
-    pub end_delay: u32,
-    /// How many times to play the sequence
-    pub times: SequenceMode,
-}
-
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-#[cfg_attr(feature = "defmt", derive(defmt::Format))]
-#[non_exhaustive]
-pub enum Error {
-    /// Max Sequence size is 32767
-    SequenceTooLong,
-    /// Min Sequence size is 1
-    SequenceTooShort,
-    /// EasyDMA can only read from data memory, read only buffers in flash will fail.
-    DMABufferNotInDataMemory,
+pub struct PwmSeq<'d, T: Instance> {
+    phantom: PhantomData<&'d mut T>,
 }
 
-impl<'d, T: Instance> Pwm<'d, T> {
+impl<'d, T: Instance> PwmSeq<'d, T> {
     /// Creates the interface to a PWM instance.
     ///
     /// Defaults the freq to 1Mhz, max_duty 32767, duty 0, and channels low.
@@ -111,11 +75,20 @@ impl<'d, T: Instance> Pwm<'d, T> {
         ch1: impl Unborrow<Target = impl GpioOptionalPin> + 'd,
         ch2: impl Unborrow<Target = impl GpioOptionalPin> + 'd,
         ch3: impl Unborrow<Target = impl GpioOptionalPin> + 'd,
-    ) -> Self {
+        config: SequenceConfig,
+    ) -> Result<Self, Error> {
+        slice_in_ram_or(config.sequence, Error::DMABufferNotInDataMemory)?;
+
+        if config.sequence.len() > 32767 {
+            return Err(Error::SequenceTooLong);
+        }
+        if let SequenceMode::Times(0) = config.times {
+            return Err(Error::SequenceTooShort);
+        }
+
         unborrow!(ch0, ch1, ch2, ch3);
 
         let r = T::regs();
-        let s = T::state();
 
         if let Some(pin) = ch0.pin_mut() {
             pin.set_low();
@@ -148,41 +121,6 @@ impl<'d, T: Instance> Pwm<'d, T> {
 
         // Enable
         r.enable.write(|w| w.enable().enabled());
-
-        r.seq0
-            .ptr
-            .write(|w| unsafe { w.bits(&s.duty as *const _ as u32) });
-        r.seq0.cnt.write(|w| unsafe { w.bits(4) });
-        r.seq0.refresh.write(|w| unsafe { w.bits(0) });
-        r.seq0.enddelay.write(|w| unsafe { w.bits(0) });
-
-        r.decoder.write(|w| {
-            w.load().individual();
-            w.mode().refresh_count()
-        });
-        r.mode.write(|w| w.updown().up());
-        r.prescaler.write(|w| w.prescaler().div_16());
-        r.countertop.write(|w| unsafe { w.countertop().bits(1000) });
-        r.loop_.write(|w| w.cnt().disabled());
-
-        Self {
-            phantom: PhantomData,
-        }
-    }
-
-    /// Play a `SequenceConfig` sequence instead of a stable `set_duty` output
-    pub fn play_sequence(&self, config: SequenceConfig) -> Result<(), Error> {
-        slice_in_ram_or(config.sequence, Error::DMABufferNotInDataMemory)?;
-
-        if config.sequence.len() > 32767 {
-            return Err(Error::SequenceTooLong);
-        }
-        if let SequenceMode::Times(0) = config.times {
-            return Err(Error::SequenceTooShort);
-        }
-
-        let r = T::regs();
-
         r.mode
             .write(|w| unsafe { w.bits(config.counter_mode as u32) });
         r.prescaler
@@ -250,12 +188,162 @@ impl<'d, T: Instance> Pwm<'d, T> {
                 r.tasks_seqstart[0].write(|w| unsafe { w.bits(0x01) });
             }
         }
-        Ok(())
+
+        Ok(Self {
+            phantom: PhantomData,
+        })
+    }
+
+    /// Stop playback
+    #[inline(always)]
+    pub fn stop(&self) {
+        let r = T::regs();
+
+        r.shorts.reset();
+
+        // tasks_stop doesnt exist in all svds so write its bit instead
+        r.tasks_stop.write(|w| unsafe { w.bits(0x01) });
+    }
+
+    /// Disables the PWM generator.
+    #[inline(always)]
+    pub fn disable(&self) {
+        let r = T::regs();
+        r.enable.write(|w| w.enable().disabled());
+    }
+}
+
+impl<'a, T: Instance> Drop for PwmSeq<'a, T> {
+    fn drop(&mut self) {
+        self.stop();
+        self.disable();
+
+        info!("pwm drop: done");
+
+        // TODO: disable pins
+    }
+}
+
+#[derive(Debug, Eq, PartialEq, Clone, Copy)]
+pub enum SequenceMode {
+    /// Run sequence n Times total
+    Times(u16),
+    /// Repeat until `stop` is called.
+    Infinite,
+}
+
+/// Configure an infinite looping sequence for `simple_playback`
+pub struct SequenceConfig<'a> {
+    /// Selects up mode or up-and-down mode for the counter
+    pub counter_mode: CounterMode,
+    /// Top value to be compared against buffer values
+    pub top: u16,
+    /// Configuration for PWM_CLK
+    pub prescaler: Prescaler,
+    /// In ram buffer to be played back
+    pub sequence: &'a [u16],
+    /// How a sequence is read from RAM and is spread to the compare register
+    pub sequence_load: SequenceLoad,
+    /// Number of Times PWM periods to delay between each sequence sample
+    pub refresh: u32,
+    /// Number of Times PWM periods after the sequence ends before starting the next sequence
+    pub end_delay: u32,
+    /// How many times to play the sequence
+    pub times: SequenceMode,
+}
+
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[cfg_attr(feature = "defmt", derive(defmt::Format))]
+#[non_exhaustive]
+pub enum Error {
+    /// Max Sequence size is 32767
+    SequenceTooLong,
+    /// Min Sequence size is 1
+    SequenceTooShort,
+    /// EasyDMA can only read from data memory, read only buffers in flash will fail.
+    DMABufferNotInDataMemory,
+}
+
+impl<'d, T: Instance> Pwm<'d, T> {
+    /// Creates the interface to a PWM instance.
+    ///
+    /// Defaults the freq to 1Mhz, max_duty 32767, duty 0, and channels low.
+    /// Must be started by calling `set_duty`
+    ///
+    /// # Safety
+    ///
+    /// The returned API is safe unless you use `mem::forget` (or similar safe
+    /// mechanisms) on stack allocated buffers which which have been passed to
+    /// [`send()`](Pwm::send) or [`receive`](Pwm::receive).
+    #[allow(unused_unsafe)]
+    pub fn new(
+        _pwm: impl Unborrow<Target = T> + 'd,
+        ch0: impl Unborrow<Target = impl GpioOptionalPin> + 'd,
+        ch1: impl Unborrow<Target = impl GpioOptionalPin> + 'd,
+        ch2: impl Unborrow<Target = impl GpioOptionalPin> + 'd,
+        ch3: impl Unborrow<Target = impl GpioOptionalPin> + 'd,
+    ) -> Self {
+        unborrow!(ch0, ch1, ch2, ch3);
+
+        let r = T::regs();
+        let s = T::state();
+
+        if let Some(pin) = ch0.pin_mut() {
+            pin.set_low();
+            pin.conf().write(|w| w.dir().output());
+        }
+        if let Some(pin) = ch1.pin_mut() {
+            pin.set_low();
+            pin.conf().write(|w| w.dir().output());
+        }
+        if let Some(pin) = ch2.pin_mut() {
+            pin.set_low();
+            pin.conf().write(|w| w.dir().output());
+        }
+        if let Some(pin) = ch3.pin_mut() {
+            pin.set_low();
+            pin.conf().write(|w| w.dir().output());
+        }
+
+        // if NoPin provided writes disconnected (top bit 1) 0x80000000 else
+        // writes pin number ex 13 (0x0D) which is connected (top bit 0)
+        r.psel.out[0].write(|w| unsafe { w.bits(ch0.psel_bits()) });
+        r.psel.out[1].write(|w| unsafe { w.bits(ch1.psel_bits()) });
+        r.psel.out[2].write(|w| unsafe { w.bits(ch2.psel_bits()) });
+        r.psel.out[3].write(|w| unsafe { w.bits(ch3.psel_bits()) });
+
+        // Disable all interrupts
+        r.intenset.reset();
+        r.intenclr.write(|w| unsafe { w.bits(0xFFFF_FFFF) });
+        r.shorts.reset();
+
+        // Enable
+        r.enable.write(|w| w.enable().enabled());
+
+        r.seq0
+            .ptr
+            .write(|w| unsafe { w.bits(&s.duty as *const _ as u32) });
+        r.seq0.cnt.write(|w| unsafe { w.bits(4) });
+        r.seq0.refresh.write(|w| unsafe { w.bits(0) });
+        r.seq0.enddelay.write(|w| unsafe { w.bits(0) });
+
+        r.decoder.write(|w| {
+            w.load().individual();
+            w.mode().refresh_count()
+        });
+        r.mode.write(|w| w.updown().up());
+        r.prescaler.write(|w| w.prescaler().div_16());
+        r.countertop.write(|w| unsafe { w.countertop().bits(1000) });
+        r.loop_.write(|w| w.cnt().disabled());
+
+        Self {
+            phantom: PhantomData,
+        }
     }
 
     /// Stop playback
     #[inline(always)]
-    pub fn sequence_stop(&self) {
+    pub fn stop(&self) {
         let r = T::regs();
 
         r.shorts.reset();
@@ -264,6 +352,7 @@ impl<'d, T: Instance> Pwm<'d, T> {
         r.tasks_stop.write(|w| unsafe { w.bits(0x01) });
     }
 
+    // todo should this do.. something useful
     /// Enables the PWM generator.
     #[inline(always)]
     pub fn enable(&self) {
@@ -271,6 +360,7 @@ impl<'d, T: Instance> Pwm<'d, T> {
         r.enable.write(|w| w.enable().enabled());
     }
 
+    // todo should this stop the task? or should you just use set_duty to 0?
     /// Disables the PWM generator.
     #[inline(always)]
     pub fn disable(&self) {
@@ -349,7 +439,7 @@ impl<'d, T: Instance> Pwm<'d, T> {
 
 impl<'a, T: Instance> Drop for Pwm<'a, T> {
     fn drop(&mut self) {
-        self.sequence_stop();
+        self.stop();
         self.disable();
 
         info!("pwm drop: done");
diff --git a/examples/nrf/src/bin/pwm_sequence.rs b/examples/nrf/src/bin/pwm_sequence.rs
index 066ab3c03..0a7bea1c4 100644
--- a/examples/nrf/src/bin/pwm_sequence.rs
+++ b/examples/nrf/src/bin/pwm_sequence.rs
@@ -7,7 +7,9 @@ mod example_common;
 use defmt::*;
 use embassy::executor::Spawner;
 use embassy::time::{Duration, Timer};
-use embassy_nrf::pwm::{CounterMode, Prescaler, Pwm, SequenceConfig, SequenceLoad, SequenceMode};
+use embassy_nrf::pwm::{
+    CounterMode, Prescaler, PwmSeq, SequenceConfig, SequenceLoad, SequenceMode,
+};
 use embassy_nrf::Peripherals;
 
 #[embassy::main]
@@ -27,8 +29,9 @@ async fn main(_spawner: Spawner, p: Peripherals) {
         times: SequenceMode::Times(5),
     };
 
-    let pwm = Pwm::new(p.PWM0, p.P0_13, p.P0_15, p.P0_16, p.P0_14);
-    unwrap!(pwm.play_sequence(config));
+    let _pwm = unwrap!(PwmSeq::new(
+        p.PWM0, p.P0_13, p.P0_15, p.P0_16, p.P0_14, config
+    ));
     info!("pwm started!");
 
     loop {
diff --git a/examples/nrf/src/bin/pwm_simple_sin.rs b/examples/nrf/src/bin/pwm_simple_sin.rs
index 3c1bddbc7..6fd59c6a4 100644
--- a/examples/nrf/src/bin/pwm_simple_sin.rs
+++ b/examples/nrf/src/bin/pwm_simple_sin.rs
@@ -9,7 +9,9 @@ use defmt::*;
 use embassy::executor::Spawner;
 use embassy::time::{Duration, Timer};
 use embassy_nrf::gpio::NoPin;
-use embassy_nrf::pwm::{CounterMode, Prescaler, Pwm, SequenceConfig, SequenceLoad, SequenceMode};
+use embassy_nrf::pwm::{
+    CounterMode, Prescaler, PwmSeq, SequenceConfig, SequenceLoad, SequenceMode,
+};
 use embassy_nrf::Peripherals;
 use micromath::F32Ext;
 
@@ -31,13 +33,12 @@ async fn main(_spawner: Spawner, p: Peripherals) {
         times: SequenceMode::Infinite,
     };
 
-    let pwm = Pwm::new(p.PWM0, p.P0_13, NoPin, NoPin, NoPin);
-    unwrap!(pwm.play_sequence(config));
+    let pwm = unwrap!(PwmSeq::new(p.PWM0, p.P0_13, NoPin, NoPin, NoPin, config));
     info!("pwm started!");
 
     Timer::after(Duration::from_millis(20000)).await;
 
-    pwm.sequence_stop();
+    pwm.stop();
     info!("pwm stopped!");
 
     loop {