diff options
| author | Dario Nieuwenhuis <[email protected]> | 2023-06-08 16:08:40 +0200 |
|---|---|---|
| committer | Dario Nieuwenhuis <[email protected]> | 2023-06-08 18:00:48 +0200 |
| commit | 921780e6bfb9bcb2cd087b8aa8b094d792c99fa2 (patch) | |
| tree | bd21fba9800471b860ca44e05567588dcc1afef7 /embassy-nrf/src/usb/mod.rs | |
| parent | 87ad66f2b4a5bfd36dfc8d8aad5492e9e3f915e6 (diff) | |
Make interrupt module more standard.
- Move typelevel interrupts to a special-purpose mod: `embassy_xx::interrupt::typelevel`.
- Reexport the PAC interrupt enum in `embassy_xx::interrupt`.
This has a few advantages:
- The `embassy_xx::interrupt` module is now more "standard".
- It works with `cortex-m` functions for manipulating interrupts, for example.
- It works with RTIC.
- the interrupt enum allows holding value that can be "any interrupt at runtime", this can't be done with typelevel irqs.
- When "const-generics on enums" is stable, we can remove the typelevel interrupts without disruptive changes to `embassy_xx::interrupt`.
Diffstat (limited to 'embassy-nrf/src/usb/mod.rs')
| -rw-r--r-- | embassy-nrf/src/usb/mod.rs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/embassy-nrf/src/usb/mod.rs b/embassy-nrf/src/usb/mod.rs index 3c62b4452..76cf40ac7 100644 --- a/embassy-nrf/src/usb/mod.rs +++ b/embassy-nrf/src/usb/mod.rs | |||
| @@ -18,9 +18,9 @@ use embassy_usb_driver::{Direction, EndpointAddress, EndpointError, EndpointInfo | |||
| 18 | use pac::usbd::RegisterBlock; | 18 | use pac::usbd::RegisterBlock; |
| 19 | 19 | ||
| 20 | use self::vbus_detect::VbusDetect; | 20 | use self::vbus_detect::VbusDetect; |
| 21 | use crate::interrupt::{self, Interrupt}; | 21 | use crate::interrupt::typelevel::Interrupt; |
| 22 | use crate::util::slice_in_ram; | 22 | use crate::util::slice_in_ram; |
| 23 | use crate::{pac, Peripheral}; | 23 | use crate::{interrupt, pac, Peripheral}; |
| 24 | 24 | ||
| 25 | const NEW_AW: AtomicWaker = AtomicWaker::new(); | 25 | const NEW_AW: AtomicWaker = AtomicWaker::new(); |
| 26 | static BUS_WAKER: AtomicWaker = NEW_AW; | 26 | static BUS_WAKER: AtomicWaker = NEW_AW; |
| @@ -34,7 +34,7 @@ pub struct InterruptHandler<T: Instance> { | |||
| 34 | _phantom: PhantomData<T>, | 34 | _phantom: PhantomData<T>, |
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | impl<T: Instance> interrupt::Handler<T::Interrupt> for InterruptHandler<T> { | 37 | impl<T: Instance> interrupt::typelevel::Handler<T::Interrupt> for InterruptHandler<T> { |
| 38 | unsafe fn on_interrupt() { | 38 | unsafe fn on_interrupt() { |
| 39 | let regs = T::regs(); | 39 | let regs = T::regs(); |
| 40 | 40 | ||
| @@ -98,7 +98,7 @@ impl<'d, T: Instance, V: VbusDetect> Driver<'d, T, V> { | |||
| 98 | /// Create a new USB driver. | 98 | /// Create a new USB driver. |
| 99 | pub fn new( | 99 | pub fn new( |
| 100 | usb: impl Peripheral<P = T> + 'd, | 100 | usb: impl Peripheral<P = T> + 'd, |
| 101 | _irq: impl interrupt::Binding<T::Interrupt, InterruptHandler<T>> + 'd, | 101 | _irq: impl interrupt::typelevel::Binding<T::Interrupt, InterruptHandler<T>> + 'd, |
| 102 | vbus_detect: V, | 102 | vbus_detect: V, |
| 103 | ) -> Self { | 103 | ) -> Self { |
| 104 | into_ref!(usb); | 104 | into_ref!(usb); |
| @@ -804,7 +804,7 @@ pub(crate) mod sealed { | |||
| 804 | /// USB peripheral instance. | 804 | /// USB peripheral instance. |
| 805 | pub trait Instance: Peripheral<P = Self> + sealed::Instance + 'static + Send { | 805 | pub trait Instance: Peripheral<P = Self> + sealed::Instance + 'static + Send { |
| 806 | /// Interrupt for this peripheral. | 806 | /// Interrupt for this peripheral. |
| 807 | type Interrupt: Interrupt; | 807 | type Interrupt: interrupt::typelevel::Interrupt; |
| 808 | } | 808 | } |
| 809 | 809 | ||
| 810 | macro_rules! impl_usb { | 810 | macro_rules! impl_usb { |
| @@ -815,7 +815,7 @@ macro_rules! impl_usb { | |||
| 815 | } | 815 | } |
| 816 | } | 816 | } |
| 817 | impl crate::usb::Instance for peripherals::$type { | 817 | impl crate::usb::Instance for peripherals::$type { |
| 818 | type Interrupt = crate::interrupt::$irq; | 818 | type Interrupt = crate::interrupt::typelevel::$irq; |
| 819 | } | 819 | } |
| 820 | }; | 820 | }; |
| 821 | } | 821 | } |
